[FFmpeg-devel] [PATCH] document rtsp.h

[Ronald S. Bultje]

Hi,

2009/2/16 Michael Niedermayer <michaelni at gmx.at>:
> On Mon, Feb 16, 2009 at 11:32:45AM -0500, Ronald S. Bultje wrote:
>> >> +    /** the seek value requested when calling av_seek_frame(). This way,
>> >> +     * the seek value is saved if we are currently paused and will be
>> >> +     * transmitted at the next PLAY RTSP command. See rtsp_read_play(). */
>> >>      int64_t seek_timestamp;
>> >
>> > do you realize that this is broken ?
>> >
>> > pause, seek to 1s from start, play 5h, pause, play
>> >
>> > the last play will seek back to 1s
>> > no? then the comment is wrong ...
>>
>> It's only used once of course (practically, the code is kind of funny
>> but I think it's correct). It's cached in case we're paused while
>> seeking.
>
> as i said, what the comment explains is _TOTALLY_ broken
> so if you say the code is not then the comment is

How about this?

    /** the seek value requested when calling av_seek_frame(). This value
     * is subsequently used as part of the "Range" parameter when emitting
     * the RTSP PLAY command. If we are currently playing, this command is
     * called instantly. If we are currently paused, this command is called
     * whenever we resume playback. Either way, the value is only used once,
     * see rtsp_read_play() and rtsp_read_seek(). */

Ronald