[FFmpeg-devel] [PATCH] H.264 timestamps in h264_parser - complete set

[Ivan Schreter]

Michael Niedermayer wrote:
> uOn Fri, Feb 20, 2009 at 04:00:34PM +0100, Ivan Schreter wrote:
>   
>> Michael Niedermayer wrote:
>>     
>>> On Fri, Feb 20, 2009 at 03:30:16PM +0100, Ivan Schreter wrote:
>>>   
>>>       
>>>> solution giving parser the control of frame duration seems cleaner to me.
>>>>     
>>>>         
>>> considering that your code depends on a 90khz clock which is not guranteed
>>> and that repeat_pict must be fixed and unambigously specified for fields
>>> anyway i dont see any advantage of ignoring a existing field ans introducing a
>>> new one
>>>
>>>   
>>>       
>> That was also my question in another post - where do I get the clock in 
>> lavc?
>>     
>
> do you really need it?
>   
Not for convergence, since we can express it via frame count. But for 
pts/dts computation, definitely. For H.264 case, the stream must have 
90kHz clock according to H.264 standard, so it should be OK. But for 
other codecs, I don't know.

Alternative would be to scale pts/dts to some common unit (e.g., 
1/1000000th second) and then rescale back.

> if its just for convergence_duration, then maybe a convergence_frames
> (different name and frame count instead of time) could be used.
>
>   
OK, I've changed it, since it's not 100% sure the codec knows the time 
base. Patch attached.

> [...]
>
>   
>> So the decoding of AVCodecParserContext.repeat_pict in H.264 must 
>> actually go to the parser (as done for MPEG video).
>>     
>
> yes
>
>
>   
>> BTW, H.264 currently only sets Picture.repeat_pict (and this one 
>> correctly), but no AVCodecParserContext.repeat_pict.
>>     
>
> indeed
>   
I'll resend new parser patches set in answer to the other post.

Regards,

Ivan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: avcodec_convdur2.patch
Type: text/x-patch
Size: 3386 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090220/91703a83/attachment.bin>