[FFmpeg-devel] [PATCH] H.264/AVCHD interlaced fixes

Ivan Schreter schreter
Thu Feb 19 23:52:22 CET 2009


Michael Niedermayer wrote:
> [...]
> second patch is not ok, same issue you change decode_nal() behavior
> you cant do that, it will not work, we need to decode just the header
> with decode_nal later it will not have a rbsp trailing byte at the end
> because where we stop is not the end, we cannot decode the whole slice.
>   
Hm, you are right. Theoretically, if the slice header consisted of only 
zero bytes, the code would truncate bit size too much. Nevertheless, the 
bit_size computation code needs to be executed for all other NAL unit types.

That means, I cannot factor it out at all and need to add an extra if in 
parse_nal_units()...

Then, the cosmetics patch is not worth applying as well.

Regards,

Ivan




More information about the ffmpeg-devel mailing list