[FFmpeg-devel] [PATCH] allow ac3 parser to modify codec_id

[Justin Ruggles]

Hi,

elupus wrote:
> Attached patch makes the AC3 parser modify codec_id so that eac3 streams
> are properly marked in for example some mpeg-ts stream from blueray and
> hddvd

The potential problem I see with this is that AC3 and E-AC3 frames can
be mixed in the same stream.  So with this patch, the codec_id would be
changed after every frame for such streams.  If the parser were modified
so that it groups together an independent frame with its subsequent
dependent frames and returns them as a single frame, then your solution
would work.  Otherwise, I think constantly flipping the codec_id might
cause some issues with those files.

> Before anybody asks....
> HDDVD.DTSHD.DDPlus.ts
> 
> Which i uploaded to incoming 2008-08-14

I'm sorry... but I cannot find that file in incoming.

Does the audio not decode?  The decoder should handle E-AC3 content just
fine even though the codec id is CODEC_ID_AC3.  I do understand that
it's better to have it marked as the correct id though.

-Justin