[FFmpeg-devel] [PATCH] HWAccel infrastructure (take 3)

[Michael Niedermayer]

On Wed, Feb 18, 2009 at 08:28:20PM +0100, Gwenole Beauchesne wrote:
> Le 18 f?vr. 09 ? 19:12, Michael Niedermayer a ?crit :
[...]
> >>> what happens with a buf of random content and buf_size of 1
> >>> will it segfault? if not how do you know how much you can copy?  
> >>> did i miss
> >>> some buf_size parameter somewhere?
> >>
> >> FFmpeg always sends correct data to users, it won't segfault and  
> >> it's not
> >> lavc's fault if users can't do a simple subtraction. ;-)
> >>
> >> so we have start_slice() with a buf+offset and end_slice() with a  
> >> buf_end,
> >> so we can reconstruct the buf_size.
> >
> > that should work, excpt why not send
> > buf+offset and buf_end in end_slice, is start still needed then?
> 
> Still and only for h263dec.c, it only depends on the level of ugliness  
> you'd accept. ;-) I am all for a single decode_slice() instead of both  
> start_slice(), end_slice() but I still haven't found a beautiful way  
> for h263dec.c (and that actually works). If you have ideas...

please explain me how
start_slice(buf)
<code>
end_slice(buf_end)

can be much cleaner than
tmp=buf
<code>
slice(tmp, buf_end)

?

i must be missing something ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090218/a9afc07b/attachment.pgp>