[FFmpeg-devel] [PATCH] H.264 timestamps in h264_parser - complete set

[Ivan Schreter]

Michael Niedermayer wrote:
> On Wed, Feb 18, 2009 at 12:33:57PM +0100, Ivan Schreter wrote:
>   
>> Michael Niedermayer wrote:
>> [...]
>>     
>>> I do not like this implementation
>>> its not hard to add a keyframe field and set that to -1 by default
>>> and treat that default as I_TYPE == keyframe
>>>   
>>>       
>> I can do that easily (also wanted originally), but what about binary 
>> compatibility? If I add a field, minor version must be bumped up, right? 
>> How do I do that?
>>     
>
> you increase minor by 1 and rest micro to 0
>
>
>   
>> Furthermore, lavf must check version of lavc whether the field exists at 
>> all.
>>
>> Again, no problem to go this way, but I simply don't know how to do it 
>> correctly. Please explain in more detail (and maybe a howto on FFmpeg 
>> website would be also a good investition :-).
>>
>> Or do we expect to have same SVN revision of lavf and lavc on the system 
>> (at least under same major/minor)?
>>     
>
> lets assume we now have
> lavc 1.2.3
> lavf 2.3.4
> then when keyframe is added
> lavc 1.3.0
> lavf 2.3.5 would depend on lavc >= 1.3.0
> the old 2.3.4 would work with 1.3.0 as well
>
>   

OK, so the attached key frame patch should do it. How do I express the 
dependency?

BTW, I think we should then address also convergence_duration as well. I 
attached a second patch to add another field (and another minor version 
bump). Or should it go together in one minor version bump?

Note: the computation of convergence duration in packet is most probably 
erroneous. I didn't find yet which information is exactly in which variable.

Regards,

Ivan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: avcodec_keyframe.patch
Type: text/x-patch
Size: 2547 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090218/9f045805/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: avcodec_convdur.patch
Type: text/x-patch
Size: 2476 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090218/9f045805/attachment-0001.bin>