[FFmpeg-devel] [PATCH] document rtsp.h

[Michael Niedermayer]

On Tue, Feb 17, 2009 at 10:28:43PM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> On Mon, Feb 16, 2009 at 11:32 AM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> > On Fri, Feb 6, 2009 at 7:34 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> On Thu, Feb 05, 2009 at 05:41:38PM -0500, Ronald S. Bultje wrote:
> >>> On Thu, Feb 5, 2009 at 12:27 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >>> > On Thu, Feb 05, 2009 at 09:24:21AM -0500, Ronald S. Bultje wrote:
> >>> >> +/**
> >>> >> + * This describes the server response to each RTSP command.
> >>> >> + */
> >>> >
> >>> >>  typedef struct RTSPHeader {
> >>> >
> >>> > poor name ...
> >>>
> >>> I can rename it if you suggest something better. :-).
> >>
> >> ServerResponse assuming your comment is correct
> >> an alternative would be ReceivedRTSPHHeader
> >
> > RTSPServerResponse seems good to me. Then the status_code inside it
> > can stay what it is since it's contained structure makes it more than
> > clear that it's part of a "server_response" already.
> 
> See attached.
[...]
> @@ -2654,7 +2654,7 @@
>      }
>  
>      /* parse each header line */
> -    memset(header, 0, sizeof(RTSPHeader));
> +    memset(header, 0, sizeof(RTSPServerResponse));

sizeof(*header)


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

He who knows, does not speak. He who speaks, does not know. -- Lao Tsu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090218/3ce9c146/attachment.pgp>