[FFmpeg-devel] [PATCH] PB-frames support for i263

[Michael Niedermayer]

On Wed, Feb 18, 2009 at 07:06:45AM -0500, compn wrote:
> On Wed, 18 Feb 2009 12:43:04 +0100, Michael Niedermayer wrote:
> >On Wed, Feb 18, 2009 at 10:40:56AM +0200, Kostya wrote:
> >> On Tue, Feb 17, 2009 at 06:48:57PM +0100, Michael Niedermayer wrote:
> >> > On Tue, Feb 17, 2009 at 08:29:36PM +0200, Kostya wrote:
> >> +            return -1;
> >
> >dont return here, just print an error
> >> +            return -1;
> >
> >dont return here, just print an error
> >> +            return -1;
> >
> >dont return here, just print an error
> >> +            return -1;
> >
> >dont return here, just print an error
> >> +            return -1;
> >
> >dont return here, just print an error
> 
> perhapse this 'try to decode even when unexpected happens' idea should
> go in ffmpeg codec howto (and cook decoder?)?
> 
> http://wiki.multimedia.cx/index.php?title=FFmpeg_codec_howto

yes, please add :)
"The decission between erroring out or not in case of unexpected data
 should be made so that the output quality is maximized.
 This means that if undamaged data is assumed then unused/resereved values
 should lead to warnings but not failure. (assumtion of slightly non compliant
 file)
 OTOH if possibly damaged data is assumed and it is assumed that the original
 did contain specific values in reserved/unused fields then finding unexpected
 values should trigger error concealment code and the decoder/demuxer should
 attempt to resync.
 The decission between these 2 should be made by using 
 AVCodecContext.error_recognition unless its a clear case where only one of
 the 2 makes sense.
"

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090218/1fef69aa/attachment.pgp>