[FFmpeg-devel] [PATCH] use new metadata API in realmedia

[Michael Niedermayer]

On Tue, Feb 17, 2009 at 05:00:53PM +0100, Aurelien Jacobs wrote:
> On Tue, 17 Feb 2009 16:38:33 +0100
> Michael Niedermayer <michaelni at gmx.at> wrote:
> 
> > On Tue, Feb 17, 2009 at 04:30:44PM +0100, Aurelien Jacobs wrote:
> > > On Tue, 17 Feb 2009 16:20:35 +0100
> > > Aurelien Jacobs <aurel at gnuage.org> wrote:
> > > 
> > > > [...]
> > > > Not as is, due to the get_byte() or get_be16(), but OK. Done with
> > > > a slightly modified get_tag().
> > > 
> > > Stupid me... Wrong patch !
> > > Attached the correct one.
> > 
> > [...]
> > > Index: libavformat/rmdec.c
> > > ===================================================================
> > > --- libavformat/rmdec.c	(r?vision 17390)
> > > +++ libavformat/rmdec.c	(copie de travail)
> > > @@ -72,6 +72,17 @@
> > >      get_strl(pb, buf, buf_size, get_byte(pb));
> > >  }
> > >  
> > > +static void get_tag(AVFormatContext *s, int wide)
> > > +{
> > > +    char buf[1024];
> > > +    int i;
> > > +    for (i=0; i<FF_ARRAY_ELEMS(ff_rm_metadata); i++) {
> > > +        int len = wide ? get_be16(s->pb) : get_byte(s->pb);
> > > +        get_strl(s->pb, buf, sizeof(buf), len);
> > > +        av_metadata_set(&s->metadata, ff_rm_metadata[i], buf);
> > > +    }
> > > +}
> > 
> > the function name seems inappropriate now
> 
> Right. Patch updated.

ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
            conveniently.
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090217/33580f97/attachment.pgp>