[FFmpeg-devel] [RFC] wma encoder regtest

[Michael Niedermayer]

On Tue, Feb 17, 2009 at 04:14:41PM +0100, Michael Niedermayer wrote:
> On Tue, Feb 17, 2009 at 03:38:19PM +0100, Benjamin Larsson wrote:
> > Michael Niedermayer wrote:
> > > On Tue, Feb 17, 2009 at 02:32:30PM +0100, Benjamin Larsson wrote:
> > >   
> > >> I suggest we disable the wmaencoder regtest. Rounding the sine tables 
> > >> and bypassing the fft didn't work on all platforms. IMO the decode test 
> > >> of encoded data is enough. 
> > >>     
> > >
> > >
> > >   
> > >> And regardless of the result I wont spend any 
> > >> more time in this matter.
> > >>     
> > >
> > > good i was alraedy confused by you continously posting patches that could
> > > not have worked
> > > if you want a fixed point FT write the 5 lines of c code that implements one
> > > and use a fixed point sin()
> > > using a float fft and float sin with funny rounding in the middle
> > >   
> > 
> > Last patch did not use a fft at all. The permute and fft call was a nop. 
> > Comparable to your suggestion of using memcpy instead. Feel free to fix 
> > the regtest in whatever way you prefer.
> 
> until i succeed in reproducing the problem i cant do anything

no luck all gcc tried on x86_32 and 64 pass reg tests, i must return this bug
as invalid until someone explains how to reproduce on x86*
and if it cant be then someone with the respective hw should investigate
and tell us what differs, that is for example
"all fft input matches, fft output differs and is attached"
"sin window differs and is attached"
telling that the md5 differs is not usefull alone...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090217/b9fbe989/attachment.pgp>