[FFmpeg-devel] [PATCH] PB-frames support for i263

[Michael Niedermayer]

On Tue, Feb 17, 2009 at 06:01:55PM +0200, Kostya wrote:
> On Tue, Feb 17, 2009 at 02:28:00PM +0100, Michael Niedermayer wrote:
> [...]
> > > @@ -6149,6 +6217,8 @@
> > >  {
> > >      int format;
> > >  
> > > +    if(s->gb.buffer_end - s->gb.buffer == 8)
> > > +        return -1;
> > >      /* picture header */
> > >      if (get_bits_long(&s->gb, 22) != 0x20) {
> > >          av_log(s->avctx, AV_LOG_ERROR, "Bad picture start code\n");
> > 
> > explain ...
> 
> Usually PB-frames in i263 are followed by 8-byte frame that is used to
> carry some additional information for B-frames. Also they don't start with
> syncmarker and one error message is better than two (+"Bad picture start code")

i very much doubt that your test is the correct way to detect them

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I hate to see young programmers poisoned by the kind of thinking
Ulrich Drepper puts forward since it is simply too narrow -- Roman Shaposhnik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090217/e7714e60/attachment.pgp>