[FFmpeg-devel] [PATCH] set flags and stuff required for XvMC instead of just checking them

[Reimar Döffinger]

On Sun, Feb 15, 2009 at 07:16:24PM +0100, Michael Niedermayer wrote:
> On Sun, Feb 15, 2009 at 07:08:22PM +0100, Reimar D?ffinger wrote:
> > On Sun, Feb 15, 2009 at 06:24:59PM +0100, Michael Niedermayer wrote:
> [...]
> > > > > you can just always set the slice flags if it works, it should be
> > > > > faster
> > > > 
> > > > SLICE_FLAG_CODED_ORDER doesn't work.
> > > 
> > > i faintly remember that this was possible in the distant past when arpi
> > > was still leading mplayer ...
> > > you are sure you dont draw the slices in the wrong pic?
> > 
> > Certainly it draws them in the wrong pic (that's easily visible), and I do
> > not know how it should ever have worked since in libvo the function prototype is:
> > > static int draw_slice(uint8_t *src[], int stride[], int w,int h,int x,int y)
> 
> i dont see how the function prototype would have prevent slices in coded order

It provides no information whether they are in coded order or not, nor
does it indicate a place where to write the data.
If you mean it could have been hard-coded to assume coded order, I guess
that's possible, but would only work for MPEG2 without additional
hacks, and would (AFAICT) not work for libmpeg2.