[FFmpeg-devel] [PATCH] set flags and stuff required for XvMC instead of just checking them

[Michael Niedermayer]

On Sun, Feb 15, 2009 at 05:47:42PM +0100, Reimar D?ffinger wrote:
> On Sun, Feb 15, 2009 at 05:20:41PM +0100, Michael Niedermayer wrote:
> > On Sun, Feb 15, 2009 at 05:09:01PM +0100, Reimar D?ffinger wrote:
> > > And to clarify: I meant that I do not know why they are user-settable in the first
> > > place.
> > 
> > well the slice flags specify the limitations of the user app,
> > if mplayers limitations between xvmc and normal vo differ this is
> > mplayers problem.
> 
> Well, as long as that check (which fails hard) is there in FFmpeg it
> is not just a limitation of the user app, and it wouldn't help a bit if
> MPlayer's XvMC supported the format that not setting SLICE_FLAG_CODED_ORDER
> would produce.

remove the check from xvmc if you like, but keep in mind that hw decoding
cannot be done without SLICE_FLAG_CODED_ORDER.


> Btw. if those flags describe user limitations their description is
> backwards, they describe how lavc behaves, not what kind of features the
> user must support. It is also unclear how using SLICE_FLAG_ALLOW_FIELD
> with actual decoding is supposed to behave, since draw_horiz_band does
> not seem to provide anything to determine if it is the top or the bottom
> field (or both) that is finished...

if so a patch exporting picture_structure in AVFrame is probably welcome
also setting y of draw_horiz_band() so that y&1 == !!second_field could
be done ...


> 
> > you can just always set the slice flags if it works, it should be
> > faster
> 
> SLICE_FLAG_CODED_ORDER doesn't work.

i faintly remember that this was possible in the distant past when arpi
was still leading mplayer ...
you are sure you dont draw the slices in the wrong pic?


> SLICE_FLAG_ALLOW_FIELD works for
> the samples I tried, but I don't think they are field coded.

you have to test with field coded mpeg2 of course ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090215/72f7062c/attachment.pgp>