[FFmpeg-devel] [PATCH] set flags and stuff required for XvMC instead of just checking them

[Reimar Döffinger]

On Sat, Feb 14, 2009 at 10:57:01PM +0100, Reimar D?ffinger wrote:
> On Sat, Feb 14, 2009 at 10:18:35PM +0100, Michael Niedermayer wrote:
> > On Sat, Feb 14, 2009 at 09:20:42PM +0100, Reimar D?ffinger wrote:
> > > I do not know what could be the purpose of checking these things except
> > > creating useless code or general sadism.
> > > The CODEC_FLAG_EMU_EDGE is from MPlayer where it comes with the great
> > > comment "//do i need that??!!"
> > > I am not willing to keep that crap around in MPlayer, so I am moving it
> > > here...
> > 
> > you cant, 
> > 
> >    /**
> >      * CODEC_FLAG_*.
> >      * - encoding: Set by user.
> >      * - decoding: Set by user.
> >      */
> >     int flags;
> > 
> > the dox say "set by user" lavc is not the user
> 
> Well, that can be taken care of.

I'd like to add that at least the checks must go (or go to decode part)
if we want to be able to select between hardware and non-hardware
decoding in get_format (currently that call is in mpeg1_decode_picture).

Greetings,
Reimar D?ffinger