[FFmpeg-devel] [PATCH] set flags and stuff required for XvMC instead of just checking them

[Michael Niedermayer]

On Sat, Feb 14, 2009 at 11:38:50PM +0100, Reimar D?ffinger wrote:
> On Sat, Feb 14, 2009 at 11:33:58PM +0100, Michael Niedermayer wrote:
> > On Sat, Feb 14, 2009 at 10:57:01PM +0100, Reimar D?ffinger wrote:
> > > On Sat, Feb 14, 2009 at 10:18:35PM +0100, Michael Niedermayer wrote:
> > > > On Sat, Feb 14, 2009 at 09:20:42PM +0100, Reimar D?ffinger wrote:
> > > > > I do not know what could be the purpose of checking these things except
> > > > > creating useless code or general sadism.
> > > > > The CODEC_FLAG_EMU_EDGE is from MPlayer where it comes with the great
> > > > > comment "//do i need that??!!"
> > > > > I am not willing to keep that crap around in MPlayer, so I am moving it
> > > > > here...
> > > > 
> > > > you cant, 
> > > > 
> > > >    /**
> > > >      * CODEC_FLAG_*.
> > > >      * - encoding: Set by user.
> > > >      * - decoding: Set by user.
> > > >      */
> > > >     int flags;
> > > > 
> > > > the dox say "set by user" lavc is not the user
> > > 
> > > Well, that can be taken care of.
> > 
> > i do not like this
> > the EMU flag is supposed to be set by the user app depending on the 
> > buffer / VO abilities and the users preferrance, its not even clear
> > what meaning this flag has for HW decoders
> 
> Note that I removed the EMU flag, I tested with MC+IDCT and just MC
> mode, and it seems to work fine without.

> The thread_count thing is something that IMHO is a good thing to allow
> lavc to set in general, 

why? lavc can just ignore thread_count if it doesnt allow threads or fail
hard.
"Editng" thread_count is a permanent thing, think of
video1, video2, video3 concatenated
if something in video2 prevents decoding with 2 threads we dont want to
block video3 from using the number the user requested


> and the slice_flags... Well, I am not sure about
> the point of them...

well then rejected (if even the patch author doesnt know why ...)


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090215/89624026/attachment.pgp>