[FFmpeg-devel] [PATCH] fix ffplay eof memleak (issue806)

[Peter Ross]

On Sat, Feb 14, 2009 at 11:19:35AM +0100, Michael Niedermayer wrote:
> On Sat, Feb 14, 2009 at 05:54:46PM +1100, Peter Ross wrote:
> > On Sat, Feb 07, 2009 at 03:03:57AM +0100, Michael Niedermayer wrote:
> > > On Sat, Feb 07, 2009 at 12:03:51PM +1100, Peter Ross wrote:
> > > > $subject.
> > > > 
> > > > XREF: https://roundup.ffmpeg.org/roundup/ffmpeg/issue806
> > > > 

> > +#define AVERROR_EOF         AVERROR(ECANCELED) /**< End of file. */

> 
> iam fine with AVERROR_EOF but not sure if ECANCELED is best ...
> but i have no other suggestioon either except maybe EPIPE

That is because POSIX doesn't have an error code for EOF/EOS.
read() returns 0 to indicate EOF, where as av_read_frame()
returns 0 to indicate success.

I'll run with EPIPE, if there aren't any other suggestions.

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090215/b9701530/attachment.pgp>