[FFmpeg-devel] XVMC Deathmatch

[Michael Niedermayer]

On Sat, Feb 14, 2009 at 09:36:00PM +0200, Ivan Kalvachev wrote:
> On 2/14/09, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Sat, Feb 14, 2009 at 06:47:43PM +0200, Ivan Kalvachev wrote:
> >> On 2/14/09, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> > Hi
> >> >
> >> > The review is below
> >> >
> >> > (due to 1-10 points)
> >> > -10 points (for each case)
> >> > breaking compilation, regtests or the code in question if the other
> >> > gladiator notices the breakage and post a note to ffmpeg-cvslog
> >> >
> >> > -10 points (for each case)
> >> > obstructing the others work or not spliting changes half sanely
> >> >
> >> >
> >> > [...]
> >> >
> >> >>#include <X11/Xlib.h>
> >> >>#include <X11/Xutil.h>
> >> >>#include <X11/Xatom.h>
> >> >>#include <X11/extensions/Xv.h>
> >> >>#include <X11/extensions/Xvlib.h>
> >> >>#include <X11/extensions/XvMClib.h>
> >> >
> >> > 10 Points:
> >> > Get rid of these includes so that the header can be included
> >> > unconditionally that is without requireing X11 headers
> >>
> >> This can't be done.
> >> Current header requirement demands including the headers needed in
> >> the given file.
> >> This means that the last XvMClib.h is needed for this header
> >> and it is X11.
> >>
> >> The only other way is to make pointer to structures into void *.
> >> I don't like it.
> >
> > the following compiles:
> > struct Str{
> >     struct Thisthing * thisthing;
> > };
> >
> >
> > struct Str func(struct Str str){
> >     str.thisthing=0;
> >     return str;
> > }
> >
> > no void and Thisthing is nowhere defined.
> >
> 
> I know that but these are defined in X11 xvmc headers
> as typedefs...

the following compiles as well, so where is the problem?

struct Str{
    struct Thisthing * thisthing;
};


struct Str func(struct Str str){
    str.thisthing=0;
    return str;
}

typedef struct Thisthing{
    int a;
}Thisthing;

struct Str func2(struct Str str){
    str.thisthing=0;
    return str;
}

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090214/7a6158f8/attachment.pgp>