[FFmpeg-devel] [PATCH] Document sws_normalizeVec()

Stefano Sabatini stefano.sabatini-lala
Sat Feb 14 18:08:04 CET 2009


On date Saturday 2009-02-14 16:31:24 +0100, Michael Niedermayer encoded:
> On Sat, Feb 14, 2009 at 04:15:26PM +0100, Stefano Sabatini wrote:
> > Hi all,
> > 
> > I'm not sure the patch implements the proper terminology, suggestions
> > are very welcome.
> > 
> > BTW, what does sws_dcVec() stands for?
> > 
> > Regards.
> > -- 
> > FFmpeg = Forgiving and Faithless Martial Puritan Embarassing Goblin
> 
> > Index: ffmpeg/libswscale/swscale.h
> > ===================================================================
> > --- ffmpeg.orig/libswscale/swscale.h	2009-02-14 16:09:00.000000000 +0100
> > +++ ffmpeg/libswscale/swscale.h	2009-02-14 16:11:53.000000000 +0100
> > @@ -165,6 +165,14 @@
> >   * Scales all the coefficients of \p a by the \p scalar value.
> >   */
> >  void sws_scaleVec(SwsVector *a, double scalar);
> > +
> > +/**
> > + * Normalizes the vector \p a for the height \p height, scaling its
> > + * coefficients by a proper value.
> 
> tip: avoid repeating information, that is the word "normalize" when the
> function name alraedy contains it
> 
> "Scales the all coefficients so that their sum equals height"
> (note ive not RTFS! just assuming that is exactly what it does)

Yes, much better, regards.
-- 
FFmpeg = Frightening and Fierce Mournful Portable Evanescent Guru
-------------- next part --------------
A non-text attachment was scrubbed...
Name: document-sws-normalize-vec.patch
Type: text/x-diff
Size: 556 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090214/a83e95e7/attachment.patch>



More information about the ffmpeg-devel mailing list