[FFmpeg-devel] XVMC Deathmatch

[Michael Niedermayer]

On Sat, Feb 14, 2009 at 05:05:06PM +0100, Aurelien Jacobs wrote:
> Michael Niedermayer wrote:
> 
> > Hi 
> > 
> > The review is below
> > 
> > [...]
> > 
> > >//the surface is needed for prediction, the codec manipulates this
> > >#define MP_XVMC_STATE_PREDICTION 2
> > >//this surface is needed for subpicture rendering
> > >#define MP_XVMC_STATE_OSD_SOURCE 4
> > >//                     1337    IDCT MCo
> > >#define MP_XVMC_RENDER_MAGIC 0x1DC711C0
> > >
> > 
> > 4 points
> > replace MP prefixes by AV/FF depending on public/private and ensure that
> > compatibility is provided until the next major ver bump but not beyond
> 
> Compatibility ??
> This never was part of public API, so we shouldn't need to ensure
> compatibility with anything...
> (this applies to other part of the review)

mplayer/libvo/vo_xvmc.c:         p_render_surface_to_show->state |= MP_XVMC_STATE_OSD_SOURCE;
mplayer/libvo/vo_xvmc.c:      if(src_rndr->state & MP_XVMC_STATE_OSD_SOURCE){
mplayer/libvo/vo_xvmc.c:            src_rndr->state &= ~MP_XVMC_STATE_OSD_SOURCE;
mplayer/libvo/vo_xvmc.c:                                  MP_XVMC_STATE_OSD_SOURCE |

well, it is used outside lavc so i thought i was supposed to be public ...


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is not what we do, but why we do it that matters.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090214/bfa465a6/attachment.pgp>