[FFmpeg-devel] [PATCH] Ogg/Speex muxer

[Peter Ross]

On Fri, Feb 06, 2009 at 12:03:41PM -0800, Baptiste Coudurier wrote:
> Hi Peter,
> 
> On 2/6/2009 8:00 AM, Peter Ross wrote:
> > $subject.
> > 

> Can the vorbis/speex comment code be applied separately and used with
> vorbis ? If so please do that so vorbis can benefit of metadata too.

It has been designed with vorbis integration in mind. Alas I am not going
to tackle this immediately, as it requires reworking of the
ff_xiph_split_headers() function.

> Should we rebuild extradata when speex is in flv and therefore contains
> none ?

Yep. Done.

Files muxed using this patch have been tested with the reference
speex decoder and various players. There are outstanding problems
conterning use of the speex 'terminator' bit, that cause stuttered
playback with some players. Each container format seems to use this
bit differently, i.e. inserting the bit after each frame, group of
frames, end of stream or not at all.

Ideally a parser is needed to remove/insert this bit.

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ogg-speex-muxer-r3.diff
Type: text/x-diff
Size: 6876 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090215/817868b3/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ff_determine_speex_mode.diff
Type: text/x-diff
Size: 1128 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090215/817868b3/attachment-0001.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090215/817868b3/attachment.pgp>