[FFmpeg-devel] [PATCH] fix heap corruption when resampling 8-bit audio

Baptiste Coudurier baptiste.coudurier
Sat Feb 14 01:02:49 CET 2009


Hi Peter,

On 2/13/2009 3:42 PM, Peter Ross wrote:
> r17163 added the 'convert to s16' logic within audio_resample().
> This works as expected when resampling from a >16-bit audio source,
> but crashes when resampling from an 8-bit audio source. The
> size of the intermediate 16-bit buffer is presently calculated
> using the input sample size, and this varies depending on the input.
> This is wrong, as the intermediate buffer is expected to store
> 16-bit samples.

Patch looks correct indeed.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no
FFmpeg maintainer                                  http://www.ffmpeg.org




More information about the ffmpeg-devel mailing list