[FFmpeg-devel] [PATCH] libavcodec/lpc.c: Fix warning about uninitialized variable

Diego Biurrun diego
Fri Feb 13 17:07:35 CET 2009


On Fri, Feb 13, 2009 at 02:21:11PM +0100, Patrik Kullman wrote:
> On Thu, 2009-02-12 at 11:12 +0530, Jai Menon wrote:
> > On Thu, Feb 12, 2009 at 8:24 AM, Justin Ruggles
> > <justin.ruggles at gmail.com> wrote:
> > > Patrik Kullman wrote:
> > >>> These 3 changes should probably be in 3 separate commits.
> > >>>
> > >>> -Justin
> > >>
> > >> How about this?
> > >>
> > >> ffmpeg-lpc-document_use_lpc.patch:
> > >> Document explanation on how use_lpc is set
> > >>
> > >> ffmpeg-lpc_assert_use_lpc.patch:
> > >> Assert that ff_lpc_calc_coefs() is called with a valid LPC method.
> > >>
> > >> ffmpeg-lpc-uninit-weight.patch:
> > >> Based on ffmpeg-lpc_assert_use_lpc.patch, remove false positive
> > >> compilation warning about weight being uninitialized.
> > >
> > > All 3 patches look good to me.
> > >
> > > BTW, should I add myself as lpc.[ch] maintainer since it was split off
> > > from a file I already maintain?
> > 
> > Yes you probably should ;) . Sorry for not doing that during the split itself
> 
> Anything preventing these from being applied?

We're waiting for Justin to take over maintainership of these files :)

Diego




More information about the ffmpeg-devel mailing list