[FFmpeg-devel] [PATCH] libavdevice/v4l2.c: av_log DEBUG cast

Luca Abeni lucabe72
Fri Feb 13 16:20:48 CET 2009


Hi all,

M?ns Rullg?rd wrote:
[...]
>>>> Please do not use "ll", it does not work on MinGW.
>>> That doesn't matter, since the entire file is Linux-specific.
>> Does this mean we can use %Lu?
>> Since that seems to work on both 32 and 64 bit Linux?
> 
> No.  %Lu, where it exists, is exactly equivalent to %llu.  %llu is
> standard and is thus always more correct.

So, what should we do here? I see 3 possibilities:
1) leave everything as it is now
2) change "PRIu64" in %llu
3) leave "PRIu64" and cast standard.id to uint64_t

I prefer solution 3), and I'll commit it in 1 day or 2 if noone object,
but I'd like to know if anyone sees a better solution.



			Thanks,
				Luca




More information about the ffmpeg-devel mailing list