[FFmpeg-devel] [PATCH] libavdevice/v4l2.c: av_log DEBUG cast

[Patrik Kullman]

On Fri, 2009-02-13 at 14:35 +0100, Reimar D?ffinger wrote:
> On Fri, Feb 13, 2009 at 02:18:56PM +0100, Patrik Kullman wrote:
> > On Tue, 2009-02-10 at 19:41 +0000, M?ns Rullg?rd wrote:
> > > Reimar D?ffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> writes:
> > > 
> > > > On Tue, Feb 10, 2009 at 06:28:52PM +0000, M?ns Rullg?rd wrote:
> > > >> Luca Abeni <lucabe72 at email.it> writes:
> > > >> > Looks like the correct patch is changing "PRIu64" in Lu (linux's __u64 
> > > >> > is not uint64_t...)
> > > >> 
> > > >> %Lu is not a standard format specifier.  The standard modifier for
> > > >> "long long" is ll, but I'm not sure what the actual underlying type
> > > >> here is.
> > > >
> > > > Please do not use "ll", it does not work on MinGW.
> > > 
> > > That doesn't matter, since the entire file is Linux-specific.
> > 
> > Does this mean we can use %Lu?
> > Since that seems to work on both 32 and 64 bit Linux?
> 
> My opinion: It will just give people bad ideas, a cast to uint64_t seems
> more appropriate to me.

Ok, posting a new patch for review then.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg-v4l2-cast.patch
Type: text/x-patch
Size: 576 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090213/e8f47dd9/attachment.bin>