[FFmpeg-devel] [PATCH] libavfilter-soc: make scale algorithm configurable

[Stefano Sabatini]

On date Monday 2009-02-09 19:45:06 +0100, Michael Niedermayer encoded:
> On Sun, Feb 08, 2009 at 11:45:34PM +0100, Stefano Sabatini wrote:
> > On date Sunday 2009-02-08 03:01:37 +0100, Michael Niedermayer encoded:
> > > On Sat, Feb 07, 2009 at 08:30:01PM +0100, Stefano Sabatini wrote:
[...]
> > > > But I agree on the limitation of the libswscale API, ideally maybe we
> > > > should be able to pass in the opaque a pointer to an already allocated
> > > > swscale context already containing sws flags + vectors + whatever,
> > > > which we could allocate with something like:
> > > 
> > > am i missing something that make this opaque stuff needed, compared to
> > > simply passing char* ?
> > 
> > I'd like to avoid to convert the sws_flags of the AVFilterGraph to a
> > string when creating and inserting the scale filter.
> > 
> > The scale filter should be able to accept in input the sws context
> > parameters from the args string.
> > 
> > But using the args interface for passing the flags from the
> > AVFilterGraph sws_flags to the scale filter is quite awkward, and
> > involves doing snprintf in the
> > query_formats/avfilter_graph_config_formats() code.
> 
> i think i prefer if args is used instead of doing funny things with
> opaque dummy contexts

New patch, but I still would prefer a solution using somehow a
SwsContext in the AVFilterGraph.

Regression tests passed.

Regards.
-- 
FFmpeg = Friendly and Friendly Meaningless Portable Elastic Geek
-------------- next part --------------
A non-text attachment was scrubbed...
Name: set-scale-flags.patch
Type: text/x-diff
Size: 2466 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090213/e4b3c7e2/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: filtergraph-sws-flags.patch
Type: text/x-diff
Size: 1840 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090213/e4b3c7e2/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: send-sws-flags-to-ffmpeg.patch
Type: text/x-diff
Size: 1191 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090213/e4b3c7e2/attachment-0002.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cosmetics.patch
Type: text/x-diff
Size: 970 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090213/e4b3c7e2/attachment-0003.patch>