[FFmpeg-devel] [PATCH][7/8] Add VA API accelerated H.264 decoding (take 4)

[Michael Niedermayer]

On Thu, Feb 12, 2009 at 01:05:19AM +0100, Gwenole Beauchesne wrote:
> Le 11 f?vr. 09 ? 21:51, Michael Niedermayer a ?crit :
> 
> >> However, an alternative is to have an AVHWAccel with init(), uninit()
> >> member functions, that's the accelerator class + an AVHWAccelCodec  
> >> which
> >> is more consistent with existing AVCodec and that would have the
> >> start_frame(), start_slice() et al. instead.
> >
> > whats the point of the extra complexity?
> 
> e.g. a means to initialize display-independent (and player- 
> independent, implementation-wise) accelerators and cleanly  
> deinitialize accelerator (lazy-allocated) data. Haven't you noticed  
> that the current VDPAU implementation is memleaking bitstream buffers?  

had i noticed, i of course would not have approved the patch ...


> I think if FFmpeg allocated data it should release it itself somehow  
> when it's not longer needed, users of the lib will generally forget  
> about it otherwise.

maybe it could be freed through AVCodecContext.release_buffer()

Besides, would the decoder output decoded surfaces it wouldnt output
the bitstream ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Thouse who are best at talking, realize last or never when they are wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090213/f28e535c/attachment.pgp>