[FFmpeg-devel] [PATCH] libavcodec/lpc.c: Fix warning about uninitialized variable

Michael Niedermayer michaelni
Thu Feb 12 09:14:04 CET 2009


On Wed, Feb 11, 2009 at 09:54:10PM -0500, Justin Ruggles wrote:
> Patrik Kullman wrote:
> >> These 3 changes should probably be in 3 separate commits.
> >>
> >> -Justin
> > 
> > How about this?
> > 
> > ffmpeg-lpc-document_use_lpc.patch:
> > Document explanation on how use_lpc is set
> > 
> > ffmpeg-lpc_assert_use_lpc.patch:
> > Assert that ff_lpc_calc_coefs() is called with a valid LPC method.
> > 
> > ffmpeg-lpc-uninit-weight.patch:
> > Based on ffmpeg-lpc_assert_use_lpc.patch, remove false positive
> > compilation warning about weight being uninitialized.
> 
> All 3 patches look good to me.
> 
> BTW, should I add myself as lpc.[ch] maintainer since it was split off
> from a file I already maintain?

yes

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I hate to see young programmers poisoned by the kind of thinking
Ulrich Drepper puts forward since it is simply too narrow -- Roman Shaposhnik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090212/108aa678/attachment.pgp>



More information about the ffmpeg-devel mailing list