[FFmpeg-devel] [PATCH] Swscale YUV2RGB table generator

[Michael Niedermayer]

On Wed, Feb 11, 2009 at 09:03:35AM +0200, Kostya wrote:
> On Mon, Feb 09, 2009 at 05:26:29PM +0100, Michael Niedermayer wrote:
> > On Mon, Feb 09, 2009 at 06:29:09PM +0200, Kostya wrote:
> > > On Mon, Feb 09, 2009 at 04:55:04PM +0100, Michael Niedermayer wrote:
> > > > On Mon, Feb 09, 2009 at 05:38:24PM +0200, Kostya wrote:
> > > [...]
> > > > >  
> > > > > prefixed a few
> > > > 
> > > > a few are not all, but anyway its not your job i admit, it was that way
> > > > already before you ...
> > > > 
> > > > you are missing a changelog update
> > > > 
> > > > besides this if your c code is as fast as what we have and all cases have
> > > > been tested and the regression checksums dont change then its ok
> > > 
> > > Err, what's the way to test it properly?
> > 
> > swscale-example is one
> > mplayer is the second
> > libavfilter the third (be carefull with auto inserted scale filters because
> > if you test one and 3 are inserted behind your back you might be confused ..)
> 
> Tested with swscale-example and fixed the bugs in generator. Now it works properly
> with all colour depths and full/reduced range.

missing changelog entry


[...]

> +static void fill_table(uint8_t* table[256], int elemsize, int inc, uint8_t *y_table)

maybe a few const could be added?

ok except these

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090212/a3274b3b/attachment.pgp>