[FFmpeg-devel] [PATCH] configure option for 32-bit MPEG audio output

[Aurelien Jacobs]

Michael Niedermayer wrote:

> On Wed, Feb 11, 2009 at 11:46:07AM +0100, Diego Biurrun wrote:
> > On Tue, Feb 10, 2009 at 10:52:45PM -0800, Mike Melanson wrote:
> > >
> > > I want to start doing automated testing of MPEG-1 audio conformance  
> > > vectors via FATE using the officially sanctioned RMS method. To that  
> > > end, FFmpeg needs to have configure-time support for 32-bit audio  
> > > output. The code is already in FFmpeg but it requires setting  
> > > CONFIG_AUDIO_NONSHORT manually in libavcodec/mpegaudio.h. I want to  
> > > remedy that with this patch.
> > 
> > Looks fine, but..
> > 
> > > --- libavcodec/mpegaudio.h	(revision 17146)
> > > +++ libavcodec/mpegaudio.h	(working copy)
> > > @@ -65,7 +63,7 @@
> > >  
> > > -#if CONFIG_MPEGAUDIO_HP && CONFIG_AUDIO_NONSHORT
> > > +#if CONFIG_MPEGAUDIO_HP && CONFIG_AUDIO_LONG
> > 
> > ..why not just
> > 
> >   if CONFIG_AUDIO_LONG
> > 
> > ?
> > 
> > Otherwise you have to pass two configure options to enable this..
> 
> is there any advantage of not enabling CONFIG_AUDIO_NONSHORT?

Last time I proposed to enable CONFIG_AUDIO_NONSHORT by default
the issue that was raised was the PSNR drop in regtest.
It is still here:

diff -u -w "/data/ffmpeg/ffmpeg"/tests/ffmpeg.regression.ref   tests/data/vsynth.regression
--- /data/ffmpeg/ffmpeg/tests/ffmpeg.regression.ref	2009-02-02 22:28:08.000000000 +0100
+++ tests/data/vsynth.regression	2009-02-11 20:00:13.000000000 +0100
@@ -172,9 +172,9 @@
 stddev:    2.84 PSNR: 39.05 bytes:  7603200/  7603200
 21f8ff9f1daacd9133683bb4ea0f50a4 *./tests/data/a-mp2.mp2
 95712 ./tests/data/a-mp2.mp2
-83f8df5d5f84480566af548bb037fceb *./tests/data/mp2.vsynth.out.wav
-stddev: 9328.41 PSNR: 16.92 bytes:  1055276/  1058444
-stddev: 4394.71 PSNR: 23.46 bytes:  1053352/  1058444
+f815b457a24b1fdc5099c2b640dd609a *./tests/data/mp2.vsynth.out.wav
+stddev: 9306.19 PSNR: 16.94 bytes:  1055276/  1058444
+stddev: 4785.84 PSNR: 22.72 bytes:  1053352/  1058444
 aefe11ab5067621a1c674859d6413891 *./tests/data/a-ac3.rm
 98203 ./tests/data/a-ac3.rm
 39878597b1d65cce473639a7d8c93b02 *./tests/data/a-g726.wav
make: *** [codectest] Error 1

Aurel