[FFmpeg-devel] [PATCH] configure option for 32-bit MPEG audio output

[Diego Biurrun]

On Tue, Feb 10, 2009 at 10:52:45PM -0800, Mike Melanson wrote:
>
> I want to start doing automated testing of MPEG-1 audio conformance  
> vectors via FATE using the officially sanctioned RMS method. To that  
> end, FFmpeg needs to have configure-time support for 32-bit audio  
> output. The code is already in FFmpeg but it requires setting  
> CONFIG_AUDIO_NONSHORT manually in libavcodec/mpegaudio.h. I want to  
> remedy that with this patch.

Looks fine, but..

> --- libavcodec/mpegaudio.h	(revision 17146)
> +++ libavcodec/mpegaudio.h	(working copy)
> @@ -65,7 +63,7 @@
>  
> -#if CONFIG_MPEGAUDIO_HP && CONFIG_AUDIO_NONSHORT
> +#if CONFIG_MPEGAUDIO_HP && CONFIG_AUDIO_LONG

..why not just

  if CONFIG_AUDIO_LONG

?

Otherwise you have to pass two configure options to enable this..

Diego