[FFmpeg-devel] [PATCH] Some documentation for swscale.h

[Michael Niedermayer]

On Wed, Feb 11, 2009 at 02:02:48AM +0100, Stefano Sabatini wrote:
> On date Tuesday 2009-02-10 02:10:50 +0100, Michael Niedermayer encoded:
> > On Tue, Feb 10, 2009 at 01:41:43AM +0100, Stefano Sabatini wrote:
> [...]
> > > Index: ffmpeg/libswscale/swscale.h
> > > ===================================================================
> > > --- ffmpeg.orig/libswscale/swscale.h	2009-02-10 01:29:25.000000000 +0100
> > > +++ ffmpeg/libswscale/swscale.h	2009-02-10 01:38:57.000000000 +0100
> > > @@ -131,8 +131,10 @@
> > >  int sws_getColorspaceDetails(struct SwsContext *c, int **inv_table, int *srcRange, int **table, int *dstRange, int *brightness, int *contrast, int *saturation);
> > >  
> > >  /**
> > > - * Returns a normalized Gaussian curve used to filter stuff
> > > + * Returns a normalized Gaussian curve used to filter.
> > 
> > is it me or did this become worse grammar wise? not that my original is
> > more than trash
> 
>  
> > > + *
> > > - * quality=3 is high quality, lower is lower quality.
> > > + * @param quality the quality of the Gaussian filter, a value of 3 is
> > > + * high quality, lower is lower quality.
> > >   */
> > >  SwsVector *sws_getGaussianVec(double variance, double quality);
> > >  
> > 
> > ok
> > 
> > 
> > > Index: ffmpeg/libswscale/swscale.h
> > > ===================================================================
> > > --- ffmpeg.orig/libswscale/swscale.h	2009-02-10 01:33:52.000000000 +0100
> > > +++ ffmpeg/libswscale/swscale.h	2009-02-10 01:33:58.000000000 +0100
> > > @@ -114,6 +114,19 @@
> > >  
> > >  void sws_freeContext(struct SwsContext *swsContext);
> > >  
> > > +/**
> > > + * Allocates and returns a scale context. You need it to perform
> > 
> > SwsContext
> > 
> > 
> > > + * successive scaling operations using sws_scale().
> > 
> > successive?
> 
> Eliminated.
> 
> > > + *
> > > + * @param srcW the width of the source image
> > > + * @param srcH the height of the source image
> > > + * @param srcFormat the source image format
> > > + * @param dstW the width of the destination image
> > > + * @param dstH the height of the destination image
> > > + * @param dstFormat the destination image format
> > > + * @param flags specify which algorithm and options to use for the rescaling
> > > + * @return a pointer to an allocated context, or NULL in case of error
> > > + */
> > 
> > ok
> 
> Updated patches, Diego's comment taken into account too.
> 
> Regards.
> -- 
> FFmpeg = Frightening and Friendly Multimedia Problematic Exciting Gadget

> Index: ffmpeg/libswscale/swscale.h
> ===================================================================
> --- ffmpeg.orig/libswscale/swscale.h	2009-02-11 01:54:24.000000000 +0100
> +++ ffmpeg/libswscale/swscale.h	2009-02-11 01:57:20.000000000 +0100
> @@ -131,8 +131,10 @@
>  int sws_getColorspaceDetails(struct SwsContext *c, int **inv_table, int *srcRange, int **table, int *dstRange, int *brightness, int *contrast, int *saturation);
>  
>  /**
> - * Returns a normalized Gaussian curve used to filter stuff
> + * Returns a normalized Gaussian filter.

That is not the same no


[...]

> Index: ffmpeg/libswscale/swscale.h
> ===================================================================
> --- ffmpeg.orig/libswscale/swscale.h	2009-02-11 01:57:20.000000000 +0100
> +++ ffmpeg/libswscale/swscale.h	2009-02-11 01:57:48.000000000 +0100
> @@ -114,6 +114,19 @@
>  
>  void sws_freeContext(struct SwsContext *swsContext);
>  
> +/**
> + * Allocates and returns a SwsContext context. You need it to perform

context context?


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090211/b6fc60d8/attachment.pgp>