[FFmpeg-devel] [PATCH]Fix bug causing crash when encoding with libschroedinger

[Anuradha Suraparaju]

Hi,

On Tue, 2009-02-10 at 15:39 +0100, Reimar D?ffinger wrote:
> On Tue, Feb 10, 2009 at 04:20:48PM +1100, Anuradha Suraparaju wrote:
> > I've attached a patch to fix the bug that causes ffmpeg to crash when
> > encoding using libschroedinger. Currently only pixel and half-pixel
> > motion vector precisions are supported in Schroedinger. Setting the
> > mv_precision field to 2 (i.e. quarter pixel) causes a crash in the
> > Schroedinger encoder calls. By not setting this parameter, we fall back
> > to the default value used in the Schroedinger library.
> 
> Even though it was applied, I have to ask: is this a bug in
> libschroedinger? If so, has this already been fixed?

It is a bug in libschroedinger. As I said, libschroedinger encoder
currently only supports pixel and half-pixel motion vector precisions.
But it doesn't flag an error when you try to set a higher motion vector
precision which leads to the crash. This hasn't been fixed yet in the
library.

> If yes, should not configure check for the new version instead?
> If no, there should obviously be some way to fix this without removing
> that call, and that fix should still be added, too.

The current ME algorithm in libschroedinger is not very efficient. Work
is being done to improve motion estimation in libschroedinger. Until
that time, I thought it will be best to go with the default motion
vector precision in the library.

Regards,
Anuradha
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel