[FFmpeg-devel] releases and stuff

[Måns Rullgård]

Diego Biurrun <diego at biurrun.de> writes:

> On Tue, Feb 10, 2009 at 04:10:06PM +0100, Benjamin Larsson wrote:
>> Diego Biurrun wrote:
>> > On Tue, Feb 10, 2009 at 03:56:47PM +0100, Diego Biurrun wrote:
>> >   
>> >> On Tue, Feb 10, 2009 at 01:17:07PM +0100, Dominik 'Rathann' Mierzejewski wrote:
>> >>     
>> >>> On Tuesday, 10 February 2009 at 00:32, Carl Eugen Hoyos wrote:
>> >>>       
>> >>>> Roman V. Shaposhnik <rvs <at> sun.com> writes:
>> >>>>
>> >>>>> -4435d87463cd6c5407bd88cca241ca56 *./tests/data/a-wmav1.asf
>> >>>>> +6f7f3116b801ea641ce14f827de05cce *./tests/data/a-wmav1.asf
>> >>>>>           
>> >>>> I remember posting an incredibly beautiful patch to fix it, fortunately I can't
>> >>>> find it now;-)
>> >>>>         
>> >>> This?
>> >>>
>> >>> Date: Sat, 22 Nov 2008 13:42:11 +0100
>> >>> Subject: Re: [FFmpeg-devel] [PATCH] correct make test failure from 15261
>> >>>  releaseuntil now (15899)
>> >>>       
>> >> Here is the patch from Carl Eugen, it does indeed fix the WMA regression
>> >> tests on PPC.  Is this acceptable?  Acceptable minus the commented-out
>> >> code I mean.
>> 
>> I strongly object. Doing regressions tests on float code is bound to 
>> trigger these things. Instead we should either rely on some SSE metric 
>> or add more valid checksums. Riddling the code with ifdefs just to 
>> satisfy a misused test system is plain stupid.
>
> Well, maybe you can live with this just for the release.  It's important
> that the regression tests pass.

If this is the kind of stuff the release will force upon us, I double
my opposition to doing releases at all.

-- 
M?ns Rullg?rd
mans at mansr.com