[FFmpeg-devel] [PATCH] libopenjpeg wrapper for jpeg2k decoding / debian package

[Diego Biurrun]

On Tue, Feb 10, 2009 at 05:05:01PM +0530, Jai Menon wrote:
> On Tue, Feb 10, 2009 at 4:57 PM, Diego Biurrun <diego at biurrun.de> wrote:
> > On Tue, Feb 10, 2009 at 04:43:29PM +0530, Jai Menon wrote:
> >>
> >> I personally don't use packages so if anyone disagrees, please comment.
> >
> > Sorry to be a bit blunt, but developing external library support without
> > using packages, i.e. different from the rest of the world and the people
> > that will use the external library support is, ummm, suboptimal to say it
> > mildly.  You need to test your stuff in the scenario it will be used.
> 
> I don't know what is the accepted definition of external library support is but
> I did try this using openjpeg source tarballs and doing a "stock" make install
> on windows and linux. I don't have the infrastructure to test it on 5 different
> distros. It works with the external libopenjpeg *library* and thats
> what the patch is for.

I just downloaded OpenJPEG and tested.  It installs a single header file:

silver:/tmp/OpenJPEG_v1_3 $ make -n install
[...]
install -m 644 -o root -g root libopenjpeg/openjpeg.h '/usr/include'

Version 1.2 of the library does the same.

Note how it completely sucks and defaults PREFIX to /usr instead of
/usr/local.  Nonetheless, it does not install into a subdirectory of
PREFIX.

Thus, when you developed libopenjpeg support for FFmpeg, you must
somehow made the gcc include path point to the root of the library
source tree, which is completely broken.  You should use the
installed header.

Diego