[FFmpeg-devel] [PATCH] Add versioning information to dlls

[Ramiro Polla]

On Mon, Feb 9, 2009 at 7:42 PM, Diego Biurrun <diego at biurrun.de> wrote:
> On Mon, Feb 09, 2009 at 06:04:09PM -0200, Ramiro Polla wrote:
>> [...]
>>
>> New patch attached.
>>
>> Changes:
>> - I couldn't get the CFLAGS += thing to work for DEPEND_CMD for .d
>> files out of .rc files, so I just renamed dllinfo.rc to dllinfo.c.
>> This way the current DEPEND_CMD catches it just fine. Then added a
>> special rule for dllinfo.c instead of generic %.rc in common.mak
>
> Elaborate.

This bit on the old patch:

+%.d: %.rc CFLAGS += -DRC_INVOKED -xc-header
+	$(DEPEND_CMD) > $@

doesn't work as expected. make doesn't seem to like the rule to make
.d from .rc, and it just doesn't create the .d file.

I see in Makefile there is:

ffplay_g$(EXESUF): FF_EXTRALIBS += $(SDL_LIBS)

I don't know why it works here, but not on the .d rule...

>> For the release effort =)
>
> :)
>
>> --- configure (revision 17100)
>> +++ configure (working copy)
>> @@ -2519,3 +2525,65 @@
>> +
>> +dllinfo_generate() {
>> +    name=$1
>> +    description=$2
>> +    version=$3
>> +    major=${version%%.*}
>> +    version_commas=`echo $version | tr . ,`,0
>
> Use $() instead of ``.

Consider it done.

Ramiro Polla