[FFmpeg-devel] [PATCH] Swscale YUV2RGB table generator

Kostya kostya.shishkov
Mon Feb 9 20:20:27 CET 2009


On Mon, Feb 09, 2009 at 07:11:11PM +0100, Michael Niedermayer wrote:
> On Mon, Feb 09, 2009 at 05:16:29PM +0100, Diego Biurrun wrote:
> > On Mon, Feb 09, 2009 at 05:38:24PM +0200, Kostya wrote:
> [...]
> > > +        cy= (cy*255) / 219;
> > > +        oy= 16<<16;
> > > +    }else{
> > > +        crv= (crv*224) / 255;
> > > +        cbu= (cbu*224) / 255;
> > > +        cgu= (cgu*224) / 255;
> > > +        cgv= (cgv*224) / 255;
> > 
> > and extra good karma from my side for spaces around =
> > 
> > 
> > Nits aside, this looks like a possibly disruptive change.
> > I have no idea if you will finish it before the release,
> > but I suggest that you commit it after the release.
> 
> id like to drop the old scaler before the release and that needs
> this.
> and IMHO if this patch is tested the risk is low

I'll try to make regression tests with new swscaler this week and run it
on PPC, x86 and x86_64 that I can reach. Personally I don't care about
release much (only as a reason to do some work ;) so the term when it will
be applied does not bother me much.

I still have some patches with destructive power at my hand - RM demuxer
overhaul and i263 PB-frames support.
 
> [...]
> 
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB




More information about the ffmpeg-devel mailing list