[FFmpeg-devel] [PATCH] Swscale YUV2RGB table generator

[Kostya]

On Mon, Feb 09, 2009 at 05:16:29PM +0100, Diego Biurrun wrote:
> On Mon, Feb 09, 2009 at 05:38:24PM +0200, Kostya wrote:
> >  
> > --- yuv2rgb2.c	(revision 0)
> > +++ yuv2rgb2.c	(revision 0)
> > @@ -0,0 +1,683 @@
> > +/*
> > + * Software YUV to RGB converter
> 
> nit: software
> 
> > + *
> > + *  Copyright (C) 2009 Konstantin Shishkov
> > + *
> > + *  MMX/MMX2 template stuff (needed for fast movntq support),
> > + *  1,4,8bpp support and context / deglobalize stuff
> > + *  by Michael Niedermayer (michaelni at gmx.at)
> 
> nit: extra space indent
> 
> > +    for(i = 0; i < 256; i++){
> 
> extra good karma for K&R style 'for (...) {'
> 
> > +    if(!fullRange){
> 
> ditto
> 
> > +        cy= (cy*255) / 219;
> > +        oy= 16<<16;
> > +    }else{
> > +        crv= (crv*224) / 255;
> > +        cbu= (cbu*224) / 255;
> > +        cgu= (cgu*224) / 255;
> > +        cgv= (cgv*224) / 255;
> 
> and extra good karma from my side for spaces around =
> 
> 
> Nits aside, this looks like a possibly disruptive change.
> I have no idea if you will finish it before the release,
> but I suggest that you commit it after the release.

It's almost finished but I suspect tuning it may take those
two weeks. It can wait in any case though.
 
> Diego