[FFmpeg-devel] [PATCH] Explicitely declare {dst, src}Format sws_get*Context() params as enum PixelFormat

[Diego Biurrun]

On Mon, Feb 09, 2009 at 05:48:46PM +0100, Stefano Sabatini wrote:
> On date Monday 2009-02-09 09:27:35 +0100, Stefano Sabatini encoded:
> > On date Sunday 2009-02-08 21:48:25 -0800, Art Clarke encoded:
> > > On Sun, Feb 8, 2009 at 3:00 PM, Stefano Sabatini
> > > <stefano.sabatini-lala at poste.it> wrote:
> > > >> I wonder if I should bump micro/minor, maybe there are some
> > > >> compatibility issues with some compilers...
> > > >
> > > > Applied.
> > > 
> > > A little late now, but you should at least bump minor;  This breaks
> > > code for swscale users who previously passed in int values (like, oh,
> > > us).
> > > 
> > > We ran into the problem because we wanted to disguise the PixelFormat
> > > dependency in other objects and hence pass-around an opaque int; we
> > > just didn't cast it when passing back into SWSContext calls because we
> > > didn't have to (until this morning when our builds started breaking).
> > > 
> > > It's a simple fix in users' code, but I think it is an API change
> > > (yes, for the better, but a change none the less).
> > 
> > So we maybe should revert it, since it breaks compatibility. If
> > someone care feel free to do it, then I'll provide a backward
> > compatible change (#if version < ...) this night.
> 
> OK to revert or there are better ideas?

If Art can live with the version bump I think reverting is not necessary.

Diego