[FFmpeg-devel] [PATCH] Swscale YUV2RGB table generator

[Michael Niedermayer]

On Mon, Feb 09, 2009 at 05:38:24PM +0200, Kostya wrote:
> On Mon, Feb 09, 2009 at 02:49:51PM +0100, Michael Niedermayer wrote:
> > On Mon, Feb 09, 2009 at 10:49:57AM +0200, Kostya wrote:
> > > On Sun, Feb 08, 2009 at 09:08:01PM +0100, Michael Niedermayer wrote:
> > > > On Sun, Feb 08, 2009 at 08:27:49PM +0200, Kostya wrote:
> > > > > Here's LGPLed version of YUV2RGB tables generator.
> > > > > While it may be not perfect, it seems to work.
> > > > > 
> > > > > Please test and/or give your comments.
> [...]
> > > Index: swscale.c
> > > ===================================================================
> > > --- swscale.c	(revision 28473)
> > > +++ swscale.c	(working copy)
> > > @@ -174,7 +174,7 @@
> > >  #define RV ( (int)(0.500*224/255*(1<<RGB2YUV_SHIFT)+0.5))
> > >  #define RU (-(int)(0.169*224/255*(1<<RGB2YUV_SHIFT)+0.5))
> > >  
> > > -extern const int32_t Inverse_Table_6_9[8][4];
> > > +extern const int32_t ff_yuv2rgb_coeffs[8][4];
> > >  
> > >  static const double rgb2yuv_table[8][9]={
> > >      {0.7152, 0.0722, 0.2126, -0.386, 0.5, -0.115, -0.454, -0.046, 0.5},
> > 
> > ok, feel free to just commit renames that add ff_ to private symbols lacking
> > a prefix (this stuff has to be a seperate commit anyway)
>  
> prefixed a few

a few are not all, but anyway its not your job i admit, it was that way
already before you ...

you are missing a changelog update

besides this if your c code is as fast as what we have and all cases have
been tested and the regression checksums dont change then its ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you really think that XML is the answer, then you definitly missunderstood
the question -- Attila Kinali
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090209/a76967c7/attachment.pgp>