[FFmpeg-devel] [PATCH] convert to S16 when resampling is requested

[Baptiste Coudurier]

Diego Biurrun wrote:
> On Sun, Feb 08, 2009 at 05:16:53PM -0800, Baptiste Coudurier wrote:
>> Baptiste Coudurier wrote:
>>> [...]
>>>
>>> +/**
>>> + *  Initialize audio resampling context
> 
> I think Michael prefers javadoc-style third person singular, i.e.
> 
>   Initializes audio resampling context.
> 
>>> + * @param output_channels number of output channels
>>> + * @param input_channels  number of input channels
>>> + * @param output_rate     output sample rate
>>> + * @param input_rate      input sample rate
> 
> fine
> 
>>> + * @param sample_fmt_out  wanted output sample format
> 
> requested output sample format
> 
>>> + * @param sample_fmt_in   input sample format
>>> + * @return allocated ReSampleContext, NULL if error occured
> 
> fine
> 
>> Forgot to ask, can you please give me a good doxygen description for
>> other params ? Would be great.
> 
> The description is OK IMO.  Or were you asking about something else?

Yes, the last 4 params, I don't know what they are, I guess Michael knows.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no
FFmpeg maintainer                                  http://www.ffmpeg.org