[FFmpeg-devel] camera files (no name)

[Vitor Sessak]

Diego Biurrun wrote:
> On Sun, Feb 08, 2009 at 10:32:35PM +0100, Vitor Sessak wrote:
>> Diego Biurrun wrote:
>>> On Sun, Feb 08, 2009 at 07:49:19PM +0100, Vitor Sessak wrote:
>>>> Michael Niedermayer wrote:
>>>>> On Sun, Feb 08, 2009 at 10:04:46AM -0500, nicolas martin wrote:
>>>>>> Le 09-02-07 ? 21:56, Michael Niedermayer a ?crit :
>>>>>>
>>>>>>> On Sat, Feb 07, 2009 at 04:40:53PM -0500, nicolas martin wrote:
>>>>>>> [...]
>>>>>>>> +static int nc_read_packet(AVFormatContext *s, AVPacket *pkt)
>>>>>>>> +{
>>>>>>>> +    int size;
>>>>>>>> +
>>>>>>>> +    uint32_t state=-1;
>>>>>>>> +    while (!url_feof(s->pb) && state != NC_VIDEO_FLAG)
>>>>>>>> +        state = (state<<8) + get_byte(s->pb);
>>>>>>>> +
>>>>>>>> +    if (url_feof(s->pb))
>>>>>>>> +        return AVERROR(EIO);
>>>>>>> while (state != NC_VIDEO_FLAG){
>>>>>>>    if (url_feof(s->pb))
>>>>>>>        return AVERROR(EIO);
>>>>>>>    state = (state<<8) + get_byte(s->pb);
>>>>>>> }
>>>>>> Fixed.
>>>>> probaly ok
>>>> Tested and applied.
>>> Your testing leaves something to be desired:
>>>
>>> ncdec.c:82: warning: ISO C90 forbids mixed declarations and code
>>>
>>> Please do not ignore warnings.
>> 10l. Ok to fix this warning moving the declaration up?
> 
> I think so, yes.

Done.

-Vitor