[FFmpeg-devel] [PATCH]ffplay 2/2: Fix subtitle rendering for special cases

[Michael Niedermayer]

On Sat, Feb 07, 2009 at 12:35:47AM +0100, Bj?rn Axelsson wrote:
> On Thu, 5 Feb 2009, Michael Niedermayer wrote:
> 
> [...]
> 
> > > blend_subrect_2.diff:
> > > Fix blend_subrect for even-width subrects positioned on odd columns.
> > >
> > > When a subrect starts on an odd column, the first column is rendered
> > > separately and the chroma pointers are increased by one as if two columns
> > > were rendered. If the subrect had an even width to start width, the rest
> > > of the subrect has now an odd width and the final column is rendered
> > > separately, also increasing the chroma pointers as if two columns were
> > > rendered. This results in the chroma part of the subtitle getting offset
> > > one additional sample to the right for each row.
> > > The effect can be seen in the first, the sixth and the seventh subtitles
> > > of the sample[1].
> >
> > this change looks wrong
> 
> Here's a cleaner approach...

probably ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
            conveniently.
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090208/49bc1177/attachment.pgp>