[FFmpeg-devel] [PATCH] don't install rtsp.h [was: document rtsp.h]

[Michael Niedermayer]

On Sat, Feb 07, 2009 at 05:10:04PM +0100, Diego Biurrun wrote:
> On Fri, Feb 06, 2009 at 05:18:31PM +0100, Michael Niedermayer wrote:
> > On Fri, Feb 06, 2009 at 03:52:13PM +0000, Carl Eugen Hoyos wrote:
> > > Michael Niedermayer <michaelni <at> gmx.at> writes:
> > > 
> > > > > Why is vdpau.h installed in libavcodec/?
> > > > 
> > > > because i skiped reviewing the build system part and the build
> > > > system maintainers either missed it or didnt complain ...
> > > 
> > > I strongly disagree: Installing vdpau.h was an explicit requirement from build
> > > system maintainer.
> > 
> > i seem to have missed that, sorry
> 
> How else is vdpau supposed to be used from outside FFmpeg?

many choices
one is
 struct vdpau_render_state {
-    VdpVideoSurface surface; ///< Used as rendered surface, never changed.
+    struct VdpVideoSurface *surface; ///< Used as rendered surface, never changed.

     int state; ///< Holds FF_VDPAU_STATE_* values.

     /** picture parameter information for all supported codecs */
-    union VdpPictureInfo {
-        VdpPictureInfoH264     h264;
-        VdpPictureInfoMPEG1Or2 mpeg;
-        VdpPictureInfoVC1       vc1;
-    } info;
+    void *pict_info;

     /** Describe size/location of the compressed video data. */
     int bitstream_buffers_allocated;
     int bitstream_buffers_used;
-    VdpBitstreamBuffer *bitstream_buffers;
+    struct VdpBitstreamBuffer *bitstream_buffers;
};

and then move this to avcodec.h and remove the #include <vdpau*

or

return just one vdpau struct if there is an appropriate one
or
define our own vdpau indepandant struct to export the fields that
then in the vo are copied into whatever struct vdpau wants
or
define our own vdpau indepandant struct to export the fields and
provide 3 functions that convert this struct to VdpVideoSurface,
VdpPictureInfo and VdpBitstreamBuffer

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090208/b30e0c95/attachment.pgp>