[FFmpeg-devel] [PATCH] install aes.h, des.h and rc4.h
Fri Feb 6 22:33:00 CET 2009
On Fri, Feb 06, 2009 at 09:53:16PM +0100, Reimar D?ffinger wrote:
> On Fri, Feb 06, 2009 at 09:17:58PM +0100, Michael Niedermayer wrote:
> > i dont like casting AVAES in stone, the inconvenience from a
> > single alloca() is not worth it
> > so not ok
> First, "casting AVAES in stone" certainly is an exaggeration, at most it
> needs a major version bump,and even that only if the size or alignment
> requirements change.
at most anything needs a major version bump. That is really as close as
a lib can be to "be cast in stone".
> Also, you know the reasons: alloca is not portable, other methods might
> not provide sufficient alignment or have other issues.
> But maybe we can find a better solution.
> What about a
> void *av_alloca(uint8_t *);
> Usage would be
> uint8_t buffer[size + AV_ALLOCA_PADDING];
> struct AVAES *a = av_alloca(buffer);
> Does that seem like it might make a good solution or does it have
> serious issues?
its not particularely pretty and something should be done to make it
less error prone, also no function call should happen just a macro
or inline function
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel