[FFmpeg-devel] [PATCH] install aes.h, des.h and rc4.h

[Michael Niedermayer]

On Fri, Feb 06, 2009 at 09:17:58PM +0100, Michael Niedermayer wrote:
> On Wed, Feb 04, 2009 at 07:12:40PM +0100, Reimar D?ffinger wrote:
[...]
> > Index: libavutil/Makefile
> > ===================================================================
> > --- libavutil/Makefile	(revision 16989)
> > +++ libavutil/Makefile	(working copy)
> > @@ -3,11 +3,13 @@
> >  NAME = avutil
> >  
> >  HEADERS = adler32.h                                                     \
> > +          aes.h                                                         \
> >            avstring.h                                                    \
> >            avutil.h                                                      \
> >            base64.h                                                      \
> >            common.h                                                      \
> >            crc.h                                                         \
> > +          des.h                                                         \
> >            fifo.h                                                        \
> >            intfloat_readwrite.h                                          \
> >            log.h                                                         \
> > @@ -17,6 +19,7 @@
> >            mem.h                                                         \
> >            random.h                                                      \
> >            rational.h                                                    \
> > +          rc4.h                                                         \
> >            sha1.h
> >  
> >  OBJS = adler32.o                                                        \
> 
> ok if you are sure that you do not want to change the API of rc4/des
> and are sure you want the struct public.

also you should add a comment to the structs and clearly say that the user
should not access the fields directly

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I hate to see young programmers poisoned by the kind of thinking
Ulrich Drepper puts forward since it is simply too narrow -- Roman Shaposhnik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090206/15913a25/attachment.pgp>