[FFmpeg-devel] please don't install libavcodec/vdpau.h [was: Re: [PATCH] don't install rtsp.h]

Michael Niedermayer michaelni
Fri Feb 6 17:43:17 CET 2009

On Fri, Feb 06, 2009 at 08:07:02AM -0800, Stephen Warren wrote:
> Gwenole Beauchesne
> > 
> > Hi,
> > 
> > On Fri, 6 Feb 2009, Ronald S. Bultje wrote:
> > 
> > >> On Fri, Feb 06, 2009 at 08:57:54AM -0500, Ronald S. Bultje wrote:
> > >>> Why is vdpau.h installed in libavcodec/?
> > >>
> > >> because i skiped reviewing the build system part and the build
> > >> system maintainers either missed it or didnt complain ...
> > >
> > > Can any of the vdpau or build people comment and possibly remove it?
> > 
> > Where should it be installed instead? In any case, this needs to be
> > installed somewhere so that video player developers can actually pass/get
> > the right data from FFmpeg.
> Indeed; during review of the patches it was specifically requested that
> this file be installed.
> As Gwenole mentioned, applications need to include this file to get the
> definition of the data structures that represent video surfaces.
> What is the problem with installing it?

The end result is ugly
i mean having in every decoder code to support XVMC, VDPAU and VAAPI
(and then DXVA and and and)
then having a header and seperate struct using a mix of structs from
these APIs installed as for the 3+ interfaces between lavc and players
with these 3+ APIs.

i mean if i compare this to the case where lavc had a single API defined
in avcodec.h or some avcodec_hwaccel.h that was used by codecs to export
information needed for the 3 hw accel APIs and then seperately provide
3 converters that convert it to XVMC/VDPAU/VAAPI compatible structs
well IMHO that would be cleaner.

Also having some converter that converts the VDPAU/VAAPI structs by
using the hardware to YV12 in a normal accessable buffer would be nice ...

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090206/874f05a6/attachment.pgp>

More information about the ffmpeg-devel mailing list