[FFmpeg-devel] [PATCH] don't install rtsp.h [was: document rtsp.h]

[Michael Niedermayer]

On Fri, Feb 06, 2009 at 07:47:08AM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> On Fri, Feb 6, 2009 at 7:34 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Thu, Feb 05, 2009 at 05:41:38PM -0500, Ronald S. Bultje wrote:
> >> On Thu, Feb 5, 2009 at 12:27 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> > On Thu, Feb 05, 2009 at 09:24:21AM -0500, Ronald S. Bultje wrote:
> >> >> +    /**
> >> >> +     * This is not part of the public API and shouldn't be used outside ffmpeg.
> >> >> +     */
> >> >>      RTSP_TRANSPORT_LAST
> >> >
> >> > this stateent makes it look like the rest is part of the public API, is
> >> > it so?
> >>
> >> Not sure, really. I'm hoping we can stop installing rtsp.h, then it
> >> isn't and the comment can be removed. Luca? I guess we should remove
> >> the comments once we stop installing rtsp.h.
> >
> > what breaks if its not installed? users really have no business bypassing
> > libav* API and acces demuxers behinds its back
> 
> OK, attached patch prevents installing rtsp.h.
> 
> What breaks is an application like ffserver.c if it were maintained
> outside of the ffmpeg source tree. Of course it isn't so we don't
> care, it's more conceptually. then again, it's broken already anyway
> since it depends on all kind of rtp/sdp headers that are not
> installed.
> 
> I'll remove the offending "This is not part of API" lines from my
> documentation patch as well.

I really like this patch and would be very happy to see this applied before
the release
luca?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090206/dced20e7/attachment.pgp>