[FFmpeg-devel] MPADecodeContext on stack

[Michael Niedermayer]

On Thu, Feb 05, 2009 at 11:02:12AM +0100, Andreas ?man wrote:
> M?ns Rullg?rd wrote:
> > You believe correctly.  Here's a list of stack offenders on ARM:
> > 
> >  262144 ff_mjpeg_decode_sos            mjpegdec.c:886
> 
> This one seem to originate from
> 
>      uint16_t buffer[32768][4];
> 
> in
> 
> ljpeg_decode_rgb_scan()
> 
> Perhaps i'm missing something, but can not the two
> for(mb_x = 0; mb_x < s->mb_width; mb_x++) -loops just be merged
> and [32768] be removed?

you miss that buffer is uint16_t while the picture is uint8_t

> 
> I don't have any lossless RGB JPEGs available to test with.

we support rgb ljpeg encoding

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090205/cdc50119/attachment.pgp>