[FFmpeg-devel] [PATCH] MTH demuxer (Gamecube format)
Michael Montanye
montanye
Thu Feb 5 05:26:36 CET 2009
Michael Niedermayer wrote:
> [...]
>
>
>> +#include "libavutil/intreadwrite.h"
>>
>
> is this needed?
>
>
Yes, for the call to AV_RL32 in mth_probe.
>> +#include "avformat.h"
>> +
>> +typedef struct MthDemuxContext {
>>
>
>
>> + int first_frame;
>> + int first_framesz;
>>
>
> unused
>
>
Fixed.
>> + int next_frame;
>>
>
> can be a local var
>
>
Fixed. And that reduced the struct to just one value, so I converted
the struct to a simple int pointer, which changed the downstream logic some.
[...]
>> + get_be32(pb); /* Framecount, not needed */
>>
>
> maybe AVStream.duration could be set with that
>
>
Okay. Fixed, new patch attached.
-Michael Montanye
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: mth-demuxer6.diff
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090204/2c161562/attachment.asc>
More information about the ffmpeg-devel
mailing list