[FFmpeg-devel] [PATCH] configure: add command flag to disable yasm use

[Jason Garrett-Glaser]

On Wed, Feb 4, 2009 at 5:20 PM, Mans Rullgard <mans at mansr.com> wrote:
> ---
>  configure |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/configure b/configure
> index 1c225a0..35a4d77 100755
> --- a/configure
> +++ b/configure
> @@ -207,6 +207,7 @@ show_help(){
>   echo "  --disable-mmi            disable MMI optimizations"
>   echo "  --disable-neon           disable neon optimizations"
>   echo "  --disable-vis            disable VIS optimizations"
> +  echo "  --disable-yasm           disable use of yasm assembler"
>   echo
>   echo "Developer options (useful when working on FFmpeg itself):"
>   echo "  --disable-debug          disable debugging symbols"
> @@ -918,6 +919,7 @@ CMDLINE_SELECT="
>     logging
>     optimizations
>     stripping
> +    yasm
>  "
>
>  PATHS_LIST='
> @@ -1787,7 +1789,7 @@ EOF
>         macho64)              append YASMFLAGS "-DPIC -DPREFIX" ;;
>         *)                    append YASMFLAGS "-DPREFIX"  ;;
>     esac
> -    check_yasm "pabsw xmm0, xmm0" && enable yasm
> +    disabled yasm || { check_yasm "pabsw xmm0, xmm0" && enable yasm; }
>  fi
>
>  # check for assembler specific support
> --
> 1.6.1.2

Now that we'll have a disable option, can we make yasm required to
build on x86/x86_64?  That is, if --disable-yasm is *not* passed and
yasm is *not* found, configure will fail (forcing people without yasm
to explicitly disable it).  Given the ever-increasing amount of yasm
asm in ffmpeg, it seems a bad idea to silently disable it; instead,
the user should have to actively say that he does not want to use
yasm.  The current system can lead to ffmpeg builds that vary wildly
in performance based on whether yasm was on the build system.

Dark Shikari